tests/Integration/Resources/DSC_SqlAlwaysOnService.Integration.Tests.ps1 (1)

69-73: Good: Using -Skip switch is correct Pester v5 syntax.

The change from -Tag 'Skip' to -Skip is appropriate—the -Skip switch actually skips test execution, whereas -Tag 'Skip' only labels the test without skipping it.

However, since this PR adds SQL Server 2025 to integration tests, consider updating the TODO comment to include Integration_SQL2025 in the tag list for when this test is re-enabled.

Also, there's a double space before the opening brace on line 73.

📝 Suggested update

 <#
     TODO: This has temporarily been disabled as the test is not passing.
-          Tags should be changed to @('Integration_SQL2016', 'Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022')
+          Tags should be changed to @('Integration_SQL2016', 'Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022', 'Integration_SQL2025')
 #>
-Describe "$($script:dscResourceName)_Integration" -Skip  {
+Describe "$($script:dscResourceName)_Integration" -Skip {

tests/Integration/Commands/Set-SqlDscDatabaseDefault.Integration.Tests.ps1 (1)

116-120: Consider moving database cleanup to AfterAll.

The test database removal is currently in an It block, which may not execute if earlier tests fail. Moving this to the AfterAll block (lines 65-68) ensures cleanup runs reliably regardless of test outcomes.

♻️ Suggested refactor

     AfterAll {
+        # Clean up the test database
+        $null = Remove-SqlDscDatabase -ServerObject $script:serverObject -Name $script:testDatabaseName -Force
+
         # Disconnect from the database engine.
         Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject
     }

Then remove the cleanup Context block (lines 116-120).

tests/Integration/Commands/Get-SqlDscTraceFlag.Integration.Tests.ps1 (1)

39-42: Consider removing unused credential variable.

$script:mockSqlAdminCredential is defined but never used in any test. The Get-SqlDscTraceFlag command uses WMI/Configuration Manager and doesn't require database credentials.

♻️ Suggested cleanup

     BeforeAll {
         $script:mockInstanceName = 'DSCSQLTEST'
         $script:mockComputerName = Get-ComputerName
 
-        $mockSqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
-        $mockSqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force
-
-        $script:mockSqlAdminCredential = [System.Management.Automation.PSCredential]::new($mockSqlAdministratorUserName, $mockSqlAdministratorPassword)
-
         # Get the service object for testing the ByServiceObject parameter set
         $script:serviceObject = Get-SqlDscManagedComputerService -ServiceType 'DatabaseEngine' -InstanceName $script:mockInstanceName -ErrorAction 'Stop'
     }

tests/Unit/SqlServerDsc.Common/Public/Connect-Sql.Tests.ps1 (1)

408-414: Consider verifying EncryptConnection property when using -Encrypt switch.

The test validates the connection instance but doesn't assert that EncryptConnection is set correctly when the -Encrypt parameter is used.

💡 Suggested enhancement

         It 'Should return the correct service instance' -Skip:($IsLinux -or $IsMacOS) {
             $databaseEngineServerObject = Connect-SQL -Encrypt -ServerName $mockExpectedDatabaseEngineServer -InstanceName $mockExpectedDatabaseEngineInstance -ErrorAction 'Stop'
             $databaseEngineServerObject.ConnectionContext.ServerInstance | Should -BeExactly "$mockExpectedDatabaseEngineServer\$mockExpectedDatabaseEngineInstance"
+            $databaseEngineServerObject.ConnectionContext.EncryptConnection | Should -BeTrue

             Should -Invoke -CommandName New-Object -Exactly -Times 1 -Scope It `
                 -ParameterFilter $mockNewObject_MicrosoftDatabaseEngine_ParameterFilter
         }

tests/Integration/Commands/Prerequisites.Integration.Tests.ps1 (1)

272-281: Remove redundant tag from inner It block.

The -Tag @('Integration_SQL2025') on Line 275 is redundant since the parent Context block at Line 272 already has this tag. Pester inherits tags from parent blocks.

♻️ Suggested fix

     Context 'Ensure TLS 1.2 is enabled' -Tag @('Integration_SQL2025') -Skip {
         # SQL Server 2025 installation can fail when TLS 1.2 is disabled:
         # https://learn.microsoft.com/en-us/sql/sql-server/sql-server-2025-known-issues?view=sql-server-ver17#sql-server-2025-installation-fails-when-tls-12-is-disabled
-        It 'Should have TLS 1.2 enabled on the node' -Tag @('Integration_SQL2025') {
+        It 'Should have TLS 1.2 enabled on the node' {
             # Test-TlsProtocol returns $true when the protocol is enabled.
             # Assert for both Server and Client registry keys.
             (Test-TlsProtocol -Protocol 'Tls12') | Should -BeTrue
             (Test-TlsProtocol -Protocol 'Tls12' -Client) | Should -BeTrue
         }
     }

tests/Integration/Resources/DSC_SqlSecureConnection.Integration.Tests.ps1 (1)

67-67: Consider adding a comment explaining why SQL Server 2025 is excluded.

The Integration_SQL2025 tag is intentionally commented out, which aligns with the PR comments about SSL/certificate trust errors in SQL Server 2025. Adding an inline comment block above this line would help future maintainers understand the exclusion reason and when it might be safe to re-enable.

💡 Suggested improvement

+<#
+    SQL Server 2025 is excluded due to certificate/SSL trust issues.
+    See: https://learn.microsoft.com/sql/relational-databases/replication/
+    "Adding a remote replication distributor fails" section.
+    TODO: Re-enable when certificate trust handling is resolved.
+#>
 Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', 'Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022') { # 'Integration_SQL2025'

tests/Integration/Commands/Remove-SqlDscAgentOperator.Integration.Tests.ps1 (1)

43-43: Consider using array syntax for tag consistency.

The Integration_SQL2025 tag addition is correct. However, this file uses comma-separated tags without the array wrapper, while other integration tests in this PR use @(...) array syntax. Both are valid, but using array syntax would improve consistency across the codebase.

🔧 Suggested change for consistency

-Describe 'Remove-SqlDscAgentOperator' -Tag 'Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022', 'Integration_SQL2025' {
+Describe 'Remove-SqlDscAgentOperator' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022', 'Integration_SQL2025') {

tests/Integration/Commands/Enable-SqlDscAgentOperator.Integration.Tests.ps1 (1)

43-43: Consider using array syntax for consistency.

The tag addition is correct. However, this file uses comma-separated values without the @() array wrapper, while other integration test files in this PR use @('tag1', 'tag2', ...) syntax.

🔧 Optional fix for consistency

-Describe 'Enable-SqlDscAgentOperator' -Tag 'Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022', 'Integration_SQL2025' {
+Describe 'Enable-SqlDscAgentOperator' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022', 'Integration_SQL2025') {

As per coding guidelines: "For single-line arrays use: @('one', 'two', 'three')"

tests/TestHelpers/CommonTestHelper.psm1 (1)

326-336: Good addition to address SQL Server 2025 certificate trust requirements.

This change addresses the SSL certificate chain trust error mentioned in the PR comments for SQL Server 2025 replication tests. Importing the self-signed certificate into Cert:\LocalMachine\Root ensures the certificate is trusted for SQL Server connections that require encryption.

Minor observation: Line 330 uses double backslashes (Cert:\\LocalMachine\\Root) in the verbose message, which will display literally. This is cosmetic only.

🔧 Optional fix for consistent path display

-        Write-Verbose -Message ('Imported certificate into Cert:\\LocalMachine\\Root with thumbprint ''{0}''.' -f $certificate.Thumbprint)
+        Write-Verbose -Message ('Imported certificate into Cert:\LocalMachine\Root with thumbprint ''{0}''.' -f $certificate.Thumbprint)